Win32 support #118
Open
Win32 support #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
reviewed
May 15, 2025
tritao
reviewed
May 15, 2025
tritao
reviewed
May 15, 2025
tritao
reviewed
May 15, 2025
tritao
reviewed
May 15, 2025
tritao
reviewed
May 15, 2025
|
I'm just a passer by, just want to say nice work, hope this can be completed and Win32 support added 👍
Left a few comments related to this before reading this, but seems like you're already aware. |
TomasBorquez
left a comment
TomasBorquez
left a comment
There was a problem hiding this comment.
left comments on some warning you were getting, also i think you can fix the indentation with clang-format project settings:
clang-format -i -style=file $(find ./ -name "*.c" -o -name "*.h")
First test - simplestSimple ninja file: cc = gcc
target = main.exe
rule link
command = $cc $flags -o $out $in
rule compile
command = $cc $flags -c $in -o $out
build main.o: compile main.c
build $target: link main.o
default $targetRan it on the same folder: Lewboski@DESKTOP-CK46RK4 MINGW64 /c/Users/Lewboski/Desktop/Programming/learn/mate/tests/01-basic-build/build
$ ./samu.exe
[1/2] gcc -c main.c -o main.o
C:\Users\Lewboski\Desktop\Programming\learn\mate\tests\01-basic-build\build\samu.exe: CreateProcess: No such file or directory
C:\Users\Lewboski\Desktop\Programming\learn\mate\tests\01-basic-build\build\samu.exe: job failed to startSecond test - varsI tested it with some variables on a single source: cc = gcc
flags = -Wall -g
cwd = C$:\Users\Lewboski\Desktop\Programming\learn\mate\tests\01-basic-build
builddir = C$:\Users\Lewboski\Desktop\Programming\learn\mate\tests\01-basic-build\build
target = $builddir/main.exe
rule link
command = $cc $flags -o $out $in
rule compile
command = $cc $flags -c $in -o $out
build $builddir/main.o: compile $cwd/src/main.c
build $target: link $builddir/main.o
default $targetRan it with -f, and got: Lewboski@DESKTOP-CK46RK4 MINGW64 /c/Users/Lewboski/Desktop/Programming/learn/mate/tests/01-basic-build
$ ./build/samu.exe -f ./build/build.ninja
C:\Users\Lewboski\Desktop\Programming\learn\mate\tests\01-basic-build\build\samu.exe: mkdirs C:\: No error
C:\Users\Lewboski\Desktop\Programming\learn\mate\tests\01-basic-build\build\samu.exe: job failed to start
C:\Users\Lewboski\Desktop\Programming\learn\mate\tests\01-basic-build\build\samu.exe: subcommand failedyou can use these as reference meanwhile testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I am another poor soul trying to add windows support.
I got basic stuff working: os-dependent jobs stuff is separated into os.h. I also fixed lots of memory leaks found with
-fsanitize-address. Posix side with new abstractions seems to work OK.Things that need fixing before windows support can be declared:
deps = msvc$variablesubstitutions are escaped with quotes, which works fine with/usr/bin/sh -c, but fails on Windows (CreateProcess does no CLI processing), when MSVC tries to compile something (cl.exe ... -c '<file') -> causeswarning D9027 : source file ''samurai\os-win32.c'' ignored.ninja_depsfrom ninja causes segfault indepsinit()(node->gen is null for some reason)O(n^2).exesuffix and usemt.exeto add manifest file -> important for UTF-8 and long paths.NMakedoes not supportGnu Make'sifeq(), it has its own syntax for conditionals. May be easier to have two Makefiles, formakeandnmakesetvbuf()is disabled in win32, bc it causes assert with bufsize zerocanonpath()and other path related APISCMakefile and related gitignores are for development only, it helps with IDE support.
There seem to be issues with formatting caused by said IDEs and TABS. Idk how to fix that :D